On 07/07/2016 03:35 AM, Denis V. Lunev wrote: > There is no need to scan allocation tables if we have mark_all_dirty flag > set. Just mark it all dirty. > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@virtuozzo.com> > CC: Stefan Hajnoczi <stefa...@redhat.com> > CC: Fam Zheng <f...@redhat.com> > CC: Kevin Wolf <kw...@redhat.com> > CC: Max Reitz <mre...@redhat.com> > CC: Jeff Cody <jc...@redhat.com> > CC: Eric Blake <ebl...@redhat.com> > --- > block/mirror.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> > > diff --git a/block/mirror.c b/block/mirror.c > index 9beda4b..7208023 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -518,7 +518,6 @@ static int mirror_dirty_init(MirrorBlockJob *s) > BlockDriverState *base = s->base; > BlockDriverState *bs = blk_bs(s->common.blk); > BlockDriverState *target_bs = blk_bs(s->target); > - bool mark_all_dirty = base == NULL && !bdrv_has_zero_init(target_bs); > uint64_t last_pause_ns; > int ret, n; > > @@ -526,6 +525,11 @@ static int mirror_dirty_init(MirrorBlockJob *s) > > last_pause_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME); > > + if (base == NULL && !bdrv_has_zero_init(target_bs)) { I might have written '!base' instead of 'base == NULL', but that's cosmetic. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature