On 6/21/07, Balazs Attila-Mihaly (Cd-MaN) <[EMAIL PROTECTED]> wrote:
As promised I'll start to provide patches for modifications I've made to the Qemu source code as part of the project. Attached you find the first of these patches - an option to dump the traffic on a virtual interface to a tcpdump compatible file. I welcome any feedback since this is the first time I contributed actual code to an open source project. My main concern is that the code performing the actual dump is bound to the vlan not to the interface (it does the saving in the "qemu_send_packet" procedure). While this is generally speaking ok (since there is usually one vlan per interface per virtual computer), I welcome any suggestion where the code should be put.
To avoid problems in 64-bit hosts, please use uint32_t etc. instead of int/short. Otherwise the patch looks fine.