On 05/04/2012 10:50 AM, Luiz Capitulino wrote:
> On Fri, 04 May 2012 18:39:06 +0200
> Paolo Bonzini <pbonz...@redhat.com> wrote:
>
>> Il 04/05/2012 17:02, Luiz Capitulino ha scritto:
>>> diff --git a/qapi-schema.json b/qapi-schema.json
>>> index 0166ec2..4dbcb26 100644
>>> --- a/qapi-schema.json
>>> +++ b/qapi-schema.json
>>> @@ -116,12 +116,14 @@
>>> #
>>> # @shutdown: guest is shut down (and -no-shutdown is in use)
>>> #
>>> +# @suspended: guest is suspended (ACPI S3)
>>> +#
>>> # @watchdog: the watchdog action is configured to pause and has been
>>> triggered
>>> ##
>>> { 'enum': 'RunState',
>>> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
>>> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
>>> - 'running', 'save-vm', 'shutdown', 'watchdog' ] }
>>> + 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
>>>
>>
>> This breaks QAPI ABI.
>>
>> Not really a breaker for this series, but it shows how we are not yet
>> ready to keep a stable ABI (as opposed to API), and thus any
>
> Having to add a new enum every time a new value is needed is going to be fun.I think Paolo's point was that new values should be added at the end of the list. Your patch, as written, changes 'watchdog' from 13th to 14th; what you should have done is left 'watchdog' at 13th and made 'suspended' be 14th. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
