Re: [RFC 7/9] whpx: add arm64 support

[Richard Henderson]

On 7/31/25 15:27, Mohamed Mediouni wrote:

@@ -885,7 +886,7 @@ if get_option('kvm').allowed() and host_os == 'linux'
    accelerators += 'CONFIG_KVM'
  endif
  if get_option('whpx').allowed() and host_os == 'windows'
-  if get_option('whpx').enabled() and host_machine.cpu() != 'x86_64'
+  if get_option('whpx').enabled() and host_machine.cpu() in ['x86_64', 
'aarch64']
      error('WHPX requires 64-bit host')

This is wrong, since the sense of "in" is incorrect.

But I think this really should be

  if cpu == 'i386'
    if get_option('whpx').enabled()
      error('WHPX requires 64-bit host')
    endif
    # Leave CONFIG_WHPX disabled
  else
    if cc.has_header('winhvplatform.h', required: get_option('whpx')) and \
       cc.has_header('winhvemulation.h', required: get_option('whpx'))
      accelerators += 'CONFIG_WHPX'
    endif
  endif

because that's the only way that the error message makes sense.

General reject of --enable-whpx on unsupported host will be handled later with

if 'CONFIG_WHPX' not in accelerators and get_option('whpx').enabled()
  error('WHPX not available on this platform')
endif

r~