On 21.04.26 23:20, Peter Xu wrote:
- * @can_postcopy: amount of data that can be migrated in postcopy
- * or in stopped state, i.e. after target start.
- * Some can also be migrated during precopy (RAM).
- * Some must be migrated after source stops
- * (block-dirty-bitmap)
Shouldn't we save this bit of information as part of MigPendingData
documentation?
Currently it seems incomplete, and it uses "can" in a bit different meanings:
+typedef struct MigPendingData {
+ /* Amount of pending bytes can be transferred in precopy or stopcopy */
this "can" is restrictive: these bytes can be transferred ONLY in precopy or
stopcopy
+ uint64_t precopy_bytes;
+ /* Amount of pending bytes can be transferred in postcopy */
this "can" _looks_ like permissive, it seems obvious that we should be able to
transfer
these bytes in precopy as well. And that's true for RAM but wrong for block
dirty bitmaps.
+ uint64_t postcopy_bytes;
+} MigPendingData;
+
--
Best regards,
Vladimir
