Michael Tokarev <[email protected]> writes: > On 26.04.2026 11:15, Michael Tokarev wrote: >> On 14.04.2026 00:45, Junjie Cao wrote: >>> This series fixes two bugs in multifd_file_recv_data() and completes >>> the positioned read/write "all" API set for QIO channels. >>> >>> Bug summary: >>> - size_t variable storing ssize_t return: -1 wraps to SIZE_MAX >>> - error_prepend() called without ERRP_GUARD(): NULL deref on short >>> read >>> Junjie Cao (4): >>> io/channel: introduce qio_channel_pread{v,}_all{,_eof}() >>> io/channel: introduce qio_channel_pwrite{v,}_all() >>> migration/file: fix type mismatch and NULL deref in >>> multifd_file_recv_data >>> tests/unit: add pread/pwrite _all tests for io channel file >>> >>> include/io/channel.h | 133 +++++++++++++++++++ >>> io/channel.c | 139 ++++++++++++++++++++ >>> migration/file.c | 13 +- >>> tests/unit/test-io-channel-file.c | 207 ++++++++++++++++++++++++++++++ >>> 4 files changed, 486 insertions(+), 6 deletions(-) >> >> Hi! >> >> Is this a qemu-stable material? The amount of new code this series >> introduces is somewhat large, but it fixes real bugs in the end. On >> the other hand, these bugs doesn't seem to be very serious, so.. I'm >> not sure :) >> >> How do you think, should we pick this up for the current stable releases? >> It applies cleanly to 10.0.x (the earliest stable series currently >> supported). > > For 10.0.x, it also needs two more changes to work: > > a5bc1ccca95 migration: simplify error reporting after channel read > 1edf0df2840 io: Add qio_channel_wait_cond() helper > > Thanks,
Hi! Sorry for the delay. I don't think we need this series for stable. It's a fairly unlikely issue.
