Re: [PATCH v3 03/14] meson, target/arm/mshv: Enable arm64 build & add initial MSHV support

[Aastha Rawat]

On Thu, Apr 23, 2026 at 11:12:43AM +1000, Richard Henderson wrote:
> On 4/21/26 15:21, Aastha Rawat wrote:
> > @@ -855,8 +856,8 @@ if get_option('kvm').allowed() and host_os == 'linux'
> >   endif
> >   if get_option('mshv').allowed() and host_os == 'linux'
> > -  if get_option('mshv').enabled() and host_machine.cpu() != 'x86_64'
> > -    error('mshv accelerator requires x64_64 host')
> > +  if get_option('mshv').enabled() and not (host_machine.cpu() in [ 
> > 'x86_64', 'aarch64' ])
> > +    error('The mshv accelerator requires an x86_64 or aarch64 host')
> >     endif
> >     accelerators += 'CONFIG_MSHV'
> >   endif
> 
> This error should be handled by
> 
> if 'CONFIG_MSHV' not in accelerators and get_option('mshv').enabled()
>   error('mshv not available on this platform')
> endif
> 
> later in meson.build.
> 
> 
> r~

Thanks for the review. I'll remove the explicit error and fold the CPU
check into the outer condition.

if 'CONFIG_MSHV' not in accelerators and get_option('mshv').enabled()
  error('mshv not available on this platform')
endif

This check is already handling the error.

Thanks,
Aastha