On Fri, Oct 19, 2012 at 11:13:53AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 04:53:24PM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 08, 2012 at 11:30:36PM -0400, Jason Baron wrote: > > > From: Jan Kiszka <jan.kis...@siemens.com> > > > > > > Both bits are added to the write-1-to-clear mask by default. As the > > > smbus device does not allow writes at all, we have to remove it from > > > that mask, also to avoid triggering a runtime assertion. > > > > > > Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> > > > Signed-off-by: Jason Baron <jba...@redhat.com> > > > > Yes but a bugger question for me is why are these writeable > > while spec says they are W1C? > > Could you please add a code comment explaining that? > > > > Spec has these bits as: 'R/WC'. So I think you are right. We should drop > the wmask setting. Also, I think the setting of w1cmask is inverted. > Shouldn't we be setting the bits in w1cmask, not clearing them? > > Yamahata, any reason not to drop the setting of wmask here?
No reason. Let's drop it. -- yamahata
