Il 22/02/2013 16:26, Paolo Bonzini ha scritto: > Il 22/02/2013 15:51, Anthony Liguori ha scritto: >>>> For obvious reasons, -vga has to stay. >> We can introduce a new option that aliases this the -vga option. >> >> [08:50 AM] anthony@titi:~/git/qemu$ grep vga *.c | wc -l >> 51 >> >> This is not in the hw/ directory. All of our internal infrastructure >> calls it VGA. It's odd to me to call it something different in the UI >> without changing the internal bits too. > > It's all in vl.c, and all about -vga. > > $ grep -c vga vl.c > 46 > > These are what are called vga_ by "mistake": > > $ git grep -c vga origin/master -- ui/ > origin/master:ui/cocoa.m:2 > origin/master:ui/console.c:27 > origin/master:ui/curses.c:2 > origin/master:ui/gtk.c:18 > origin/master:ui/sdl.c:10 > origin/master:ui/spice-core.c:1 > origin/master:ui/spice-display.c:1 > origin/master:ui/vgafont.h:1 > origin/master:ui/vnc.c:5 > > What about: > > - s/vga_hw_/guest_display_/ (e.g. guest_display_invalidate) > > - "Guest" or "Display" or "Guest display" for the GTK UI (and similarly > in the code, e.g. gd_on_guest_display)?
Saw Jan's v2, it looks like s/vga_hw_/screen_/ would also have no conflicts. Paolo
