On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction states. > > I find it confusing to call the single structure "States". This patch > renames it to "State", just like BlockDriverState is singular. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > blockdev.c | 104 > ++++++++++++++++++++++++++++++------------------------------- > 1 file changed, 52 insertions(+), 52 deletions(-)
Mechanical, and singular makes sense to me (for a given callback, you are dealing with the single state for that callback, not all the states chained into the transaction). Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
