[Qemu-devel] Re: [PATCH 5/9] Don't call apic functions directly from kvm code

[Avi Kivity]

On 12/02/2009 03:46 PM, Glauber Costa wrote:
It is actually not necessary to call a tpr function to save and load cr8,
as cr8 is part of the processor state, and thus, it is much easier
to just add it to CPUState.
As for apic base, wrap kvm usages, so we can call either the qemu device,
or the in kernel version.
   

@@ -789,8 +802,8 @@ int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
      else
          env->eflags&= ~IF_MASK;

-    cpu_set_apic_tpr(env, run->cr8);
-    cpu_set_apic_base(env, run->apic_base);
+    env->cr8 = run->cr8;
+    kvm_set_apic_base(env, run->apic_base);

   

This will break irqchip-in-qemu, since the APIC tpr will be disconnected 
from the guest's cr8.

--
error compiling committee.c: too many arguments to function