Il 11/06/2014 10:01, Alexander Graf ha scritto:
Personally, I don't see anything wrong in these patches, apart from
the typo that Cornelia pointed out.
If you wanted to inject an NMI on non-sPAPR machines, such as -M mac99
or -M g3beige you would have to trigger an interrupt with the MPIC, not
the CPU itself.
But right now inject-nmi was a CPU-specific interface and whoever needs
something different will have to find a way.
You could argue that Alexey does need something different thanks to his
need to inject the NMI on all CPUs.
What about an NMIMonitorHandler interface that takes a Monitor*, and
then you iterate on all of /machine looking for implementors of the
interface? Then -M mac99 can add it to the MPIC, -M spapr can just
ignore the Monitor*, and i386/s390 can look at the current CPU.
Paolo
