On 06/24/2014 04:06 PM, Peter Lieven wrote: > this patch fixes the incorrect usage of strncmp and > adds simple error checking by means of parse_uint_full > instead of atoi for the supplied URL parameters. > > Signed-off-by: Peter Lieven <p...@kamp.de> > --- > block/nfs.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) >
> + if (parse_uint_full(qp->p[i].value, &val, 0)) {
> + error_setg(errp, "Illegal value for NFS parameter: %s",
I prefer s/Illegal/Invalid/, as this is not a case of breaking a law.
But that's aesthetic. Whether or not you tweak that choice of wording:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
