On Wed, 6 May 2015 09:42:26 -0300
Eduardo Habkost <ehabk...@redhat.com> wrote:
> On Mon, Apr 27, 2015 at 04:53:19PM +0200, Michael Mueller wrote:
> [...]
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 215a7bc..285b2d3 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -2536,21 +2536,43 @@
> > #
> > # @name: the name of the CPU definition
> > #
> > +# @default: #optional true if cpu model is the default,
> > +# omitted if false (since 2.4)
>
> Maybe we should clarify that it is the default in the machine provided
> as argument to query-cpu-definitions?
>
> > +#
> > +# @runnable: #optional true if cpu model is runnable,
> > +# omitted if false (since 2.4)
>
> Maybe we should clarify that it means the CPU model is runnable using
> the machine+accel combination provided as arguments to
> query-cpu-definitions?
I will extend the comments accordingly.
>
> (See also my question about the meaning of runnable when machine is
> omitted, in my reply to patch 15/17).
>
> > +#
> > +# @live-migration-safe: #optional true if cpu model represents a
> > +# cpu model that is safely migratable
> > +# omitted if false (since 2.4)
> > +#
> > +# @order: #optional order criterion
> > +#
> > # Since: 1.2.0
> > ##
> > { 'type': 'CpuDefinitionInfo',
> > - 'data': { 'name': 'str' } }
> > + 'data': { 'name': 'str', '*is-default': 'bool', '*runnable': 'bool',
> > + '*live-migration-safe': 'bool', '*order': 'int' } }
> >
> > ##
> > # @query-cpu-definitions:
> > #
> > -# Return a list of supported virtual CPU definitions
> > +# Return a list of supported virtual CPU definitions. In context with the
> > +# optional parameters @machine and @accel the returned list contains
> > +# also information if the respective cpu definition is runnable or the
> > +# default to be used.
> > +#
> > +# @machine: #optional machine type (since 2.4)
> > +#
> > +# @accel: #optional accelerator id (since 2.4)
> > #
> > # Returns: a list of CpuDefInfo
> > #
> > # Since: 1.2.0
> > ##
> > -{ 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'] }
> > +{ 'command': 'query-cpu-definitions',
> > + 'data': { '*machine': 'str', '*accel': 'AccelId' },
> > + 'returns': ['CpuDefinitionInfo'] }
> >
>
