On 17/06/2015 16:02, Michael S. Tsirkin wrote: > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not, > > what would be your preference? > > PCI_BRIDGE_DEV_F_SHPC_REQ
Do not abbrev unless necessary. :) What about PCI_BRIDGE_DEV_F_HAS_SHPC or even just PCI_BRIDGE_DEV_F_SHPC? Paolo > Also add macro for "shpc" property string to avoid duplication. > Also clear msi explicitly - no need for that to depend on shpc. >