On 13/08/2015 15:05, Frederic Konrad wrote: >> >> >> This removes tcg_halt_cond global variable. >> We need one QemuCond per virtual cpu for multithread TCG. >> >> Signed-off-by: KONRAD Frederic <fred.kon...@greensocs.com> >> Message-Id: <1439220437-23957-9-git-send-email-fred.kon...@greensocs.com> >> [Keep tcg_halt_cond for bisectability, while making it static. - Paolo] > How does that help bisectability?
With your patch (08/19), QEMU will only wait on first_cpu->halt_cond but will call broadcast on cpu->halt_cond. Here I do the opposite: I wait on cpu->halt_cond from some random CPU, but all of them point to the same condvar tcg_halt_cond. Paolo