+-- On Tue, 22 Dec 2015, Miao Yan wrote --+ | > If '1' indicates the error, the 'default:' case in the same switch needs to be | > updated too. | | '1' indicates an error on device activation. Not sure about the 'unknown | command' case.
Ideally it should be same, inconsistent return codes wouldn't be helpful. | Linux driver uses VXMNET3_READ_BAR1_REG() which calls readl(). | That should be an indication that the driver expects 32bit values. Right. | But the prototype in MemoryRegionOps requires uint64_t. That is odd. It does not seem right to use uint64_t for 32bit values, and then return a negative(-1) value. @Dmitry...? -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
