On Mon, Aug 30, 2010 at 7:32 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > On 08/30/10 21:02, Anthony Liguori wrote: >> >> On 08/30/2010 01:58 PM, Blue Swirl wrote: >>> >>> Wilful misconduct? May I ask if there are other things that you don't >>> agree with and you are covertly working against? > > I'm just not used to it. Changing habits takes time. > > I think I became better meanwhile on avoiding "if (NULL == ptr)" ;)
Thank you! I'm also just not used to that ;-) >> Braces should be used. The discussion was about enforcing coding style >> at commit time and reformatting code. > > The discussion started with unhappiness about the current situation (code > not matching code style being committed). I've seen messages discussing > whenever we should change code style or commit policy. I qickly stopped > following the huge thread though, thats why I ask. > >> But for the most part, people agree that we want braces to be used on >> single line ifs. > > Ok, so code style stays as-is. Anyone has a code style git commit hook > ready for me? So I can let git do the style review and I don't waste > everybody's time with that boring stuff? That's the plan. I tried Coccinelle but there were other problems with that approach.
