>>>> >>>> -target_ulong helper_4xx_tlbre_hi (target_ulong entry) >>>> +target_ulong helper_4xx_tlbre_lo (target_ulong entry) >>> >>> Huh? >> >> To summarize, 'tlbre' has two forms: one to retrieve the high bits of >> a TLB entry (TLBHI), and one to retrieve the low bits (TLBLO) of a TLB >> entry. This code had the TLBLO form returning the bits corresponding >> to TLBHI and vice versa, hence the name change. You can verify this >> if you like with this IBM PowerPC 405 core user manual on page 362: > > Well the thing that strikes me as weird is mostly that you're changing a > function name, but no callers to it. So is this function never used? Or was > tlbre_lo defined before already and is now defined twice?
You'll see that helper_4xx_tlbre_hi changes to helper_4xx_tlbre_lo and that helper_4xx_tlbre_lo changes to helper_4xx_tlbre_hi, so helper_4xx_tlbre_lo is not multiply defined. > > PS: Please use the "reply to all" function of your mailer. Others might be > interested in the reply too :). > Yes, I realized my mistake a few minutes after sending the previous reply and corrected it. - John
