Re: [Qemu-devel] [PATCH 02/29] 9pfs: remove side-effects in local_init()

[Stefan Hajnoczi]

On Mon, Feb 20, 2017 at 03:39:34PM +0100, Greg Kurz wrote:
> If this function fails, it should not modify *ctx.
> 
> Signed-off-by: Greg Kurz <gr...@kaod.org>
> ---
>  hw/9pfs/9p-local.c |   37 +++++++++++++++++++------------------
>  1 file changed, 19 insertions(+), 18 deletions(-)
> 
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index 7de07e1ba67f..55903e5d7745 100644
> --- a/hw/9pfs/9p-local.c
> +++ b/hw/9pfs/9p-local.c
> @@ -1168,9 +1168,25 @@ static int local_ioc_getversion(FsContext *ctx, 
> V9fsPath *path,
>  
>  static int local_init(FsContext *ctx)
>  {
> -    int err = 0;
>      struct statfs stbuf;
>  
> +#ifdef FS_IOC_GETVERSION
> +    /*
> +     * use ioc_getversion only if the iocl is definied

s/iocl/ioctl/

Otherwise:
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

signature.asc
Description: PGP signature