On Fri, Jul 21, 2017 at 03:53:23PM +0200, Markus Armbruster wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the commit before previous. > > The case in qpci_plug_device_test() is a bit complicated: it > interpolates several JSON object members, not just a value. Clean it > up by passing them in as QDict rather than string, so we can leave > interpolation to qmp() here and to qobject_from_jsonf() in callers. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > tests/ivshmem-test.c | 10 +++++----- > tests/libqos/pci.c | 33 ++++++++++++++++++--------------- > tests/libqos/pci.h | 2 +- > tests/virtio-blk-test.c | 5 ++++- > 4 files changed, 28 insertions(+), 22 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
