On 02/08/2018 09:31 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > --- > target/arm/helper-a64.c | 34 ++++++++++++++++++++++++++++++++++ > target/arm/helper-a64.h | 2 ++ > target/arm/translate-a64.c | 6 ++++++ > 3 files changed, 42 insertions(+) > > diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c > index bdfcac111f..6358b42472 100644 > --- a/target/arm/helper-a64.c > +++ b/target/arm/helper-a64.c > @@ -192,6 +192,10 @@ uint64_t HELPER(neon_cgt_f64)(float64 a, float64 b, void > *fpstp) > * versions, these do a fully fused multiply-add or > * multiply-add-and-halve. > */ > +#define float16_two make_float16(0x4000) > +#define float16_three make_float16(0x4200) > +#define float16_one_point_five make_float16(0x3e00) > + > #define float32_two make_float32(0x40000000) > #define float32_three make_float32(0x40400000) > #define float32_one_point_five make_float32(0x3fc00000)
I think we should move these somewhere else, some header where we don't have to keep re-defining them in various files within target/arm. I know, for instance, that I need floatN_two in translate-sve.c. Just putting them in softfloat.h is probably best. Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
