On 07/09/2018 10:33 AM, Peter Maydell wrote: >> Well... ok. We should document that this, surprisingly, does not include >> actual ram. Just things that are ram with caveats. > > I think it must include actual RAM, or we would not be able to > execute from actual RAM ? The only way to get to get_page_addr_code()'s > "here's the ram_addr_t for this" exit path is if memory_region_is_unassigned() > returns false. > >>> - return mr != &io_mem_rom && mr != &io_mem_notdirty && !mr->rom_device >>> - && mr != &io_mem_watch;
Huh. I don't follow how this old expression excludes ram, and so assumed that must be checked separately earlier. There's clearly still something here I don't understand. r~