Marc-André Lureau <marcandre.lur...@redhat.com> writes: > Hi, > > This series is a rebased subset of "[PATCH v3 00/38] RFC: monitor: add > asynchronous command type" with code cleanups and improvements that > are worth to consider for 3.0. > > The series applies on master, and will conflict with the pending > series "[PATCH 0/9] monitor: enable OOB by default" from Peter. > > In particular, reverting "qmp: isolate responses into io thread" is > quite intrusive, but is a nice simplification that is worth to > consider before modifying/maintaining it further. Also, "monitor: no > need to save need_resume" could be dropped if Peter "[PATCH 5/9] > monitor: suspend monitor instead of send CMD_DROP" is adopted (see > discussion about need_resume there). > > The last patch, "RFC: qmp: rework 'id' handling" simplifies a bit > monitor "id" handling, and makes qemu-ga conform to the QMP > specification by copying "id" from the request in the reply. This is > the opposite to Markus change "qmp qemu-ga: Revert change that > accidentally made qemu-ga accept 'id'". > > (the first patch is already in Markus qapi-next branch, it is there > for patchew testing) [...]
I took the liberty to rebase this onto my "[PATCH 00/56] json: Fixes, error reporting improvements, cleanups", which is by the way also available at http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/json-fixes > Marc-André Lureau (18): > tests: change /0.15/* tests to /qmp/* Kept (not really part of this series, as noted above) > monitor: consitify qmp_send_response() QDict argument > qmp: constify qmp_is_oob() > Revert "qmp: isolate responses into io thread" > monitor: no need to save need_resume Kept, has my R-by. I figure the last two need to be considered in context of OOB work that hasn't landed, yet. Discussed in review of v1. > qga: process_event() simplification and leak fix Already in master as commit ae7da1e5f6. > qmp: drop json_parser_parse() wrapper Replaced by my series. > json-parser: simplify and avoid JSONParserContext allocation Picked into my series. > json-parser: further simplify freeing JSONParserContext > qjson: report an error if there are multiple results > qjson: report error on unterminated string > qjson: return parsing error if unterminated input > json-parser: set an error if parsing returned NULL Replaced by my series. > json-lexer: make it safe to call multiple times > tests: add a few qemu-qmp tests > tests: add a qmp success-response test > qga: process_event() simplification > RFC: qmp: common 'id' handling & make QGA conform to QMP spec Kept, only the success-response test has my R-by. Result: http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/elmarco-monitor [...]
