On Mon, Apr 22, 2019 at 11:56:18PM +0200, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 4/22/19 11:04 PM, Eduardo Habkost wrote: > > QTest has two parts: the server (-qtest) and the accelerator > > (-machine accel=qtest). The accelerator depends on CONFIG_POSIX > > due to its usage of sigwait(), but the server doesn't. > > > > Move the accel code to accel/qtest.c. Later we will disable > > compilation of accel/qtest.c on non-POSIX systems. > > [...] > > +#include "qemu/module.h" > > Why include "qemu/module.h"? > I guess you don't need it.
That's where the type_init() macro is defined. > > +type_init(qtest_type_init); [...] > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks! -- Eduardo
