Patchew URL: https://patchew.org/QEMU/1573792691-398-1-git-send-email-tsimp...@quicinc.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Modify tests to work with clang Type: series Message-id: 1573792691-398-1-git-send-email-tsimp...@quicinc.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 40fa5c0 Modify tests to work with clang === OUTPUT BEGIN === WARNING: Block comments use a leading /* on a separate line #18: FILE: tests/tcg/multiarch/float_helpers.c:29: +/*---------------------------------------------------------------------------- WARNING: Block comments use * on subsequent lines #19: FILE: tests/tcg/multiarch/float_helpers.c:30: +/*---------------------------------------------------------------------------- +| The macro QEMU_GNUC_PREREQ tests for minimum version of the GNU C compiler. WARNING: Block comments use a trailing */ on a separate line #21: FILE: tests/tcg/multiarch/float_helpers.c:32: +*----------------------------------------------------------------------------*/ WARNING: architecture specific defines should be avoided #22: FILE: tests/tcg/multiarch/float_helpers.c:33: +#if defined(__GNUC__) && defined(__GNUC_MINOR__) WARNING: architecture specific defines should be avoided #37: FILE: tests/tcg/multiarch/float_helpers.c:93: +# if defined(__clang__) || QEMU_GNUC_PREREQ(3, 3) ERROR: Use of volatile is usually wrong, please add a comment #50: FILE: tests/tcg/multiarch/linux-test.c:488: + *(volatile uint8_t *)0 = 0; total: 1 errors, 5 warnings, 33 lines checked Commit 40fa5c0d7a1b (Modify tests to work with clang) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1573792691-398-1-git-send-email-tsimp...@quicinc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
