On 2019/12/11 15:57, Thomas Huth wrote:
> Hi!
>
> On 11/12/2019 01.55, pannengy...@huawei.com wrote:
> [...]
>> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
>> index 91ea373..54be931 100644
>> --- a/tests/vhost-user-test.c
>> +++ b/tests/vhost-user-test.c
>> @@ -717,6 +717,8 @@ static void test_migrate(void *obj, void *arg,
>> QGuestAllocator *alloc)
>> guint64 size;
>>
>> if (!wait_for_fds(s)) {
>> + g_free(uri);
>> + test_server_free(dest);
>> return;
>> }
>
> Well spotted. But I'd prefer to rather move the allocation of these
> resources after the if-statement instead of doing the allocation at the
> declaration of the variables already. Or maybe use a "goto out" and jump
> to the end of the function instead? ... whatever you prefer, but
> duplicating the "free" functions sounds like a cumbersome solution to me.
>
Yes, I think use a "goto out" is more better. I will change it.
Thanks.
> Thanks,
> Thomas
>
>
