On 2011-07-25 11:41, Richard W.M. Jones wrote: > On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka <jan.kis...@siemens.com> >> >> -machine somehow suggests that it selects the machine, but it doesn't. >> Fix that before this command is set in stone. >> >> Actually, -machine should supersede -M and allow to introduce arbitrary >> per-machine options to the command line. That will change the internal >> realization again, but we will be able to keep the user interface >> stable. > > This breaks libguestfs which was doing: > > qemu -machine accel=kvm:tcg ... > > We are not passing any -M option at all. We don't particularly care > about the machine type since we're not that performance sensitive and > we don't need to serialize the machine state. > > I have checked, and this works: > > qemu -machine pc,accel=kvm:tcg ... > > "pc" is the default, right? What about for other architectures?
Yes, pc is the right default. Other arch have other defaults. > > Please add qemu capabilities, so we can reasonably detect what an > unknown qemu binary supports and so we don't need to do endless > parsing of the -help output and guesswork. This syntax was not yet released (but will be with 0.15, so I was pushing this). Therefore, nothing was "officially" broken by this patch. I'm sorry if you may have released any libguestfs with the transient syntax, but my patches were waiting quite a while for being merged since the introduction of -machine. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
