On 20-07-20 13:37:46, Klaus Jensen wrote: > From: Klaus Jensen <k.jen...@samsung.com> > > Always destroy the request qsg/iov at the end of request use. > > Signed-off-by: Klaus Jensen <k.jen...@samsung.com> > --- > hw/block/nvme.c | 48 +++++++++++++++++------------------------------- > 1 file changed, 17 insertions(+), 31 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 54cd20f1ce22..b53afdeb3fb6 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -213,6 +213,14 @@ static void nvme_req_clear(NvmeRequest *req) > { > req->ns = NULL; > memset(&req->cqe, 0x0, sizeof(req->cqe)); > + > + if (req->qsg.sg) { > + qemu_sglist_destroy(&req->qsg); > + } > + > + if (req->iov.iov) { > + qemu_iovec_destroy(&req->iov); > + }
Oh okay. This looks like update for the previous patch in this series. And I also agree on starting to make focus on nvme_req_clear() for wrap-up. Looks good to me. Reviewed-by: Minwoo Im <minwoo.im....@gmail.com>