On Jul 30 00:49, Minwoo Im wrote: > Klaus, > > On 20-07-20 13:37:38, Klaus Jensen wrote: > > From: Klaus Jensen <k.jen...@samsung.com> > > > > Pass along the NvmeRequest in various functions since it is very useful > > for tracing. > > One doubt here. > This patch has put NvmeRequest argument to the nvme_map_prp() to trace > the request's command id. But can we just trace the cid before this > kind of prp mapping, somewhere like nvme_process_sq() level. Then we > can figure out the tracing for the prp mapping is from which request. > > Tracing for cid is definitely great, but feels like too much cost to > pass argument to trace 'cid' in the middle of the dma mapping stage. >
Good point Minwoo. I ended up dropping the patch and just replacing it with a patch that adds tracing to nvme_map_prp.
