On 8/14/20 9:39 AM, Philippe Mathieu-Daudé wrote:
> +static void avr_usart_update_baudrate(AVRUsartState *s)
> +{
> + unsigned baudrate = (clock_get_hz(s->clkin) / USART_CLOCK_DIVISOR)
> + / (((s->brrh << 8) | s->brrl) + 1);
> +
> + trace_avr_usart_update_baudrate((s->brrh << 8) | s->brrl, baudrate);
Would you pull that brrh|brrl expression out and give it a name?
I do wonder if one division would be better, e.g.
baudrate = clock_get_hz / (DIVISOR * (regval + 1))
r~
