On 9/28/20 4:13 PM, Daniel P. Berrangé wrote: > On Mon, Sep 28, 2020 at 03:09:01PM +0100, David CARLIER wrote: >> Unfortunately it breaks the build. > > Can you provide details of the errors seen and toolchain versions. > > I notice we don't have any CI support for Haiku right now, nor > any recipe in tests/vm/ for enabling users to setup a VM with > Haiku installed. This very much makes Haiku a second class > citizen right now in terms of QEMU's supported platforms, with > no expectation of whether it'll work at any point in time.
I provided the tests/vm/ build script from Alexander as patch 8/8 of this series: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg10022.html This is what I used to test this patch/series. > >> On Mon, 28 Sep 2020 at 14:20, Philippe Mathieu-Daudé <phi...@redhat.com> >> wrote: >>> >>> Since commit efc6c070aca ("configure: Add a test for the minimum >>> compiler version") the minimum compiler version required for GCC >>> is 4.8, which supports __builtin_bswap(). >>> Remove the Haiku specific ifdef'ry. >>> >>> This reverts commit 652a46ebba970017c7a23767dcc983265cdb8eb7 >>> ("bswap.h: Include <endian.h> on Haiku for bswap operations"). >>> >>> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >>> --- >>> Cc: David Carlier <devne...@gmail.com> >>> Cc: Carlo Arenas <care...@gmail.com> >>> --- >>> include/qemu/bswap.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h >>> index 55916670d39..719d620bfe6 100644 >>> --- a/include/qemu/bswap.h >>> +++ b/include/qemu/bswap.h >>> @@ -8,8 +8,6 @@ >>> # include <machine/bswap.h> >>> #elif defined(__FreeBSD__) >>> # include <sys/endian.h> >>> -#elif defined(__HAIKU__) >>> -# include <endian.h> >>> #else >>> #undef bswap16 >>> #define bswap16(_x) __builtin_bswap16(_x) >>> -- >>> 2.26.2 >>> >> > > Regards, > Daniel >
