On Wed, 2020-11-04 at 09:48 -0800, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20201104173217.417538-1-mlevi...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20201104173217.417538-1-mlevi...@redhat.com > Subject: [PATCH 0/5] SCSI: fix transfer limits for SCSI passthrough > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > b1266b6..3c8c36c master -> master > - [tag update] patchew/20201104160021.2342108-1-ehabk...@redhat.com -> > patchew/20201104160021.2342108-1-ehabk...@redhat.com > * [new tag] patchew/20201104173217.417538-1-mlevi...@redhat.com -> > patchew/20201104173217.417538-1-mlevi...@redhat.com > Switched to a new branch 'test' > bde6371 block/scsi: correctly emulate the VPD block limits page > c4180d6 block: use blk_get_max_ioctl_transfer for SCSI passthrough > 9ff7edc block: add max_ioctl_transfer to BlockLimits > dd2f1f7 file-posix: add sg_get_max_segments that actually works with sg > f9ad940 file-posix: split hdev_refresh_limits from raw_refresh_limits > > === OUTPUT BEGIN === > 1/5 Checking commit f9ad9400e011 (file-posix: split hdev_refresh_limits from > raw_refresh_limits) > 2/5 Checking commit dd2f1f77a5d2 (file-posix: add sg_get_max_segments that > actually works with sg) > 3/5 Checking commit 9ff7edc31002 (block: add max_ioctl_transfer to > BlockLimits) > 4/5 Checking commit c4180d6accff (block: use blk_get_max_ioctl_transfer for > SCSI passthrough) > 5/5 Checking commit bde637139536 (block/scsi: correctly emulate the VPD block > limits page) > ERROR: braces {} are necessary for all arms of this statement > #51: FILE: hw/scsi/scsi-generic.c:196: > + if (page_idx >= r->buflen) Sorry about that. Triple checked this code for correctness, but didn't run checkpatch on the last revision :-(
Best regards, Maxim Levitsky > [...] > > total: 1 errors, 0 warnings, 53 lines checked > > Patch 5/5 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20201104173217.417538-1-mlevi...@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com