Hello all,
On 12/17/20 7:46 PM, Eduardo Habkost wrote:
> From: Vitaly Kuznetsov <vkuzn...@redhat.com>
>
> As a preparation to expanding Hyper-V CPU features early, move
> hyperv_vendor_id initialization to x86_cpu_realizefn(). Introduce
> x86_cpu_hyperv_realize() to not not pollute x86_cpu_realizefn()
> itself.
this seems to fit very well the ongoing work on separating accelerator specific
realize functions;
related to the previous discussions about the class hierarchies,
do you think that we should have a separate class in target/i386/kvm/ for a
hyperv variant of the kvm-cpu.c?
Should it be a separate class or a subclass of "kvm-accel-x86_64-cpu" ?
Thanks,
Claudio
> Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com>
> Message-Id: <20201119103221.1665171-2-vkuzn...@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
> ---
> target/i386/cpu.h | 3 ++-
> target/i386/cpu.c | 23 ++++++++++++++++++++++-
> target/i386/kvm/kvm.c | 25 ++++++++++---------------
> 3 files changed, 34 insertions(+), 17 deletions(-)
>
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index 343e51baab..ad9ef559fc 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -1659,11 +1659,12 @@ struct X86CPU {
> uint64_t ucode_rev;
>
> uint32_t hyperv_spinlock_attempts;
> - char *hyperv_vendor_id;
> + char *hyperv_vendor;
> bool hyperv_synic_kvm_only;
> uint64_t hyperv_features;
> bool hyperv_passthrough;
> OnOffAuto hyperv_no_nonarch_cs;
> + uint32_t hyperv_vendor_id[3];
>
> bool check_cpuid;
> bool enforce_cpuid;
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 77f0e44df8..599526406a 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -6544,6 +6544,25 @@ static void x86_cpu_filter_features(X86CPU *cpu, bool
> verbose)
> }
> }
>
> +static void x86_cpu_hyperv_realize(X86CPU *cpu)
> +{
> + size_t len;
> +
> + /* Hyper-V vendor id */
> + if (!cpu->hyperv_vendor) {
> + memcpy(cpu->hyperv_vendor_id, "Microsoft Hv", 12);
> + } else {
> + len = strlen(cpu->hyperv_vendor);
> +
> + if (len > 12) {
> + warn_report("hv-vendor-id truncated to 12 characters");
> + len = 12;
> + }
> + memset(cpu->hyperv_vendor_id, 0, 12);
> + memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len);
> + }
> +}
> +
> static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> {
> CPUState *cs = CPU(dev);
> @@ -6715,6 +6734,8 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
> **errp)
> env->cache_info_amd.l3_cache = &legacy_l3_cache;
> }
>
> + /* Process Hyper-V enlightenments */
> + x86_cpu_hyperv_realize(cpu);
>
> cpu_exec_realizefn(cs, &local_err);
> if (local_err != NULL) {
> @@ -7218,7 +7239,7 @@ static Property x86_cpu_properties[] = {
> DEFINE_PROP_UINT32("min-xlevel2", X86CPU, env.cpuid_min_xlevel2, 0),
> DEFINE_PROP_UINT64("ucode-rev", X86CPU, ucode_rev, 0),
> DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_auto_level,
> true),
> - DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor_id),
> + DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor),
> DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true),
> DEFINE_PROP_BOOL("lmce", X86CPU, enable_lmce, false),
> DEFINE_PROP_BOOL("l3-cache", X86CPU, enable_l3_cache, true),
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index bcfa4b03e0..6a5d91e39f 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -1208,6 +1208,13 @@ static int hyperv_handle_properties(CPUState *cs,
> memcpy(cpuid_ent, &cpuid->entries[0],
> cpuid->nent * sizeof(cpuid->entries[0]));
>
> + c = cpuid_find_entry(cpuid, HV_CPUID_VENDOR_AND_MAX_FUNCTIONS, 0);
> + if (c) {
> + cpu->hyperv_vendor_id[0] = c->ebx;
> + cpu->hyperv_vendor_id[1] = c->ecx;
> + cpu->hyperv_vendor_id[2] = c->edx;
> + }
> +
> c = cpuid_find_entry(cpuid, HV_CPUID_FEATURES, 0);
> if (c) {
> env->features[FEAT_HYPERV_EAX] = c->eax;
> @@ -1282,23 +1289,11 @@ static int hyperv_handle_properties(CPUState *cs,
>
> c = &cpuid_ent[cpuid_i++];
> c->function = HV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
> - if (!cpu->hyperv_vendor_id) {
> - memcpy(signature, "Microsoft Hv", 12);
> - } else {
> - size_t len = strlen(cpu->hyperv_vendor_id);
> -
> - if (len > 12) {
> - error_report("hv-vendor-id truncated to 12 characters");
> - len = 12;
> - }
> - memset(signature, 0, 12);
> - memcpy(signature, cpu->hyperv_vendor_id, len);
> - }
> c->eax = hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS) ?
> HV_CPUID_NESTED_FEATURES : HV_CPUID_IMPLEMENT_LIMITS;
> - c->ebx = signature[0];
> - c->ecx = signature[1];
> - c->edx = signature[2];
> + c->ebx = cpu->hyperv_vendor_id[0];
> + c->ecx = cpu->hyperv_vendor_id[1];
> + c->edx = cpu->hyperv_vendor_id[2];
>
> c = &cpuid_ent[cpuid_i++];
> c->function = HV_CPUID_INTERFACE;
>
