Hi Ben, On 1/13/21 6:56 PM, Philippe Mathieu-Daudé wrote: > On 1/13/21 2:27 PM, Bin Meng wrote: >> Hi Philippe, >> >>>> Unfortunately this series breaks SPI flash testing under both U-Boot >>>> and VxWorks 7. >>> >>> Thanks for testing :) Can you provide the binary tested and the command >>> line used? At least one, so I can have a look. >> >> Sure, will send you offline. > > Arf, stupid mistake in patch 7 :) With this diff I can run your > test: > > -- >8 -- > --- a/hw/ssi/imx_spi.c > +++ b/hw/ssi/imx_spi.c > @@ -343,7 +343,7 @@ static void imx_spi_write(void *opaque, hwaddr > offset, uint64_t value, > return; > } > s->regs[ECSPI_CONREG] = value; > - if (value & ECSPI_CONREG_EN) { > + if (!(value & ECSPI_CONREG_EN)) { > /* Keep disabled */ > return; > } > ---
Could you have a try at this? Do you prefer I resubmit the whole series? Thanks, Phil.