On 12 January 2012 22:42, Peter Maydell <peter.mayd...@linaro.org> wrote: > You're the one changing what was previously a known-to-be-32-bit > type to one that's much bigger, you get to fix the printing > issues.
...which isn't to say that I don't think this is a good plan (indeed I suspect I'm going to need wider physaddrs for Cortex-A15 at some point :-)), just that I think we ought to have at least a sketch of how the average device for which the offset is going to be <4096, let alone <32bits can print messages involving the offsets without it looking really ugly in either the code or the output (and that where in this patch you're actually touching output formats you should use whatever the reasonable-looking thing is rather than just something that compiles.) -- PMM