On 2012-02-16 00:35, Anthony Liguori wrote: > On 02/15/2012 05:16 PM, Igor Mammedov wrote: >> Adds ability to hot-add cpus if guest was started with options >> -smp X,maxcpus=Y >> where X< Y. >> For simplicity sake this implementation doesn't allow to add specific >> cpu but rather it adds the next not yet plugged cpu. >> >> For adding cpu just execute following command in monitor: >> device_add cpu-pc >> If guest was started with a specific cpu model, then add option model >> to cmonitor command. for example: >> device_add cpu-pc,model="host" >> >> Signed-off-by: Igor Mammedov<imamm...@redhat.com> > > I don't see how the code matches this description, but unless you've got > qdev-ification patches in the earlier ones (haven't made the list yet), > device_add is not the right place for this. > > There's no such thing as "cpu-pc" either. You should start with a cpu_add > command.
The proper ordering is first qdev'ify x86 CPUs, then use device_add. No new throw-away commands, please. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
