On Wed, 21 Jul 2004, Matt Sergeant wrote:

> On 20 Jul 2004, at 22:46, Robin Bowes wrote:
>
> > 550-Response: 501 could not parse your mail from command
>
> This was a bug in CVS, now fixed. Why are you trying to use a CVS
> version on a live system? It's not considered stable yet. Use 0.28.

Isn't all this, because Brian Grossman suggested the following patch on
25/11/03, which after discussion, Matt, you agreed with the next day.
However, in 0.28 (released on 5/6/04) this patch had still not made it in?

diff -u qpsmtpd-cvs/lib/Qpsmtpd/SMTP.pm-orig
qpsmtpd-cvs/lib/Qpsmtpd/SMTP.pm
--- qpsmtpd-cvs/lib/Qpsmtpd/SMTP.pm-orig        Sun Nov 23 17:02:15 2003
+++ qpsmtpd-cvs/lib/Qpsmtpd/SMTP.pm     Tue Nov 25 04:53:07 2003
@@ -209,7 +209,7 @@
     my ($from) = ($from_parameter =~ m/^from:\s*(\S+)/i)[0];
     warn "$$ from email address : [$from]\n";
     if ($from eq "<>" or $from =~ m/\[undefined\]/) {
-      $from = Mail::Address->new("<>");
+      $from = Mail::Address->new('','');

I know this problem did not bite you, Matt, but I encountered it with 0.28
and Mail::Address 1.62 under perl v5.8.4 and perl v5.005_03:

rhea:/var/qmail/qpsmtpd # perl -MMail::Address -le 'print
$Mail::Address::VERSION; print Mail::Address->new("<>")->address'
1.62

rhea:/var/qmail/qpsmtpd # perl -MMail::Address -le 'printress
$Mail::Address::VERSION; print Mail::Address->new("<>")->format'
1.62
"<>"

I know in that 2nd instance you said your string did not include the
quotes, but it does for many others.
  Cheers.

-- 
Mark Powell - UNIX System Administrator - The University of Salford
Information Services Division, Clifford Whitworth Building,
Salford University, Manchester, M5 4WT, UK.
Tel: +44 161 295 4837  Fax: +44 161 295 5888  www.pgp.com for PGP key

Reply via email to