On Thu, 18 Jun 2009, Ask Bj?rn Hansen wrote:
On Jun 17, 2009, at 8:13, Filippo Carletti wrote:
+++ qpsmtpd-0.40/plugins/check_spamhelo 2007-06-14 13:21:45.000000000 -0600
@@ -23,7 +23,7 @@
for my $bad ($self->qp->config('badhelo')) {
if ($host eq lc $bad) {
$self->log(LOGDEBUG, "Denying HELO from host claiming to be $bad");
- return (DENY, "Sorry, I don't believe that you are $host.");
+ return (DENY_DISCONNECT, "Sorry, I don't believe that you are
$host.");
Is this a good idea now?
IMO yes. I don't think there is any purpose served in staying connected to
a client you don't wish to (and won't) talk to.
It's not as though there are any SMTP clients out there which will try
again with a different helo host. Unless there is a spambot tuned for this
qpsmtpd plugin.
It used to be that so many MTAs got confused when
you refused a connection before RCPT TO that it was better to wait.
This isn't related to refusing a connection.
I don't understand your statement here. In what way would any client be
better off with a connection help open following the DENY, than having
DENY_DISCONNECT?
I guess this plugin won't catch any legitimate mailers anyway ...
It certainly shouldn't.
I'll apply it.
Thanks.
The rest of the patches looked good, too. I'll apply them tomorrow. I'll
attribute the rhsbl and spamassassin ones to Charlie and the others to you?
I think perhaps this one was mine, but not others. We'd better check.
Thanks for going back through your changes and getting them submitted!
- ask
