Hi all,
I think I hit a minor bug in quilt push. When I try to push a patch with
matching square brackets (like "[PATCH]_something.patch"), quilt push
complains that the patch seems to be empty (but works otherwise).
I have narrowed the problem down to these lines in push:
if [ "$(shopt -s nullglob ; echo $QUILT_PC/$patch/*)" = "" ]
then
printf $"Patch %s appears to be empty, applied\n" \
"$(print_patch $patch)"
elif...
I think that the nullglob applies to $patch here, while it was really
only intended for *, and this is the problem. Thus we probably should
change this line to:
if [ "$(shopt -s nullglob ; echo "$QUILT_PC/$patch"/*)" = "" ]
i.e. protect the variables with double quotes. I'm not exactly sure it's
syntaxically correct, as we are already inside double quotes, and my
editor won't colorize it properly. However it seems to work just fine
for me. Comments?
Patch against CVS attached, if it happens to be the correct fix.
Thanks,
--
Jean Delvare
Index: quilt/push.in
===================================================================
RCS file: /cvsroot/quilt/quilt/quilt/push.in,v
retrieving revision 1.33
diff -u -r1.33 push.in
--- quilt/push.in 6 Feb 2005 00:35:23 -0000 1.33
+++ quilt/push.in 11 May 2005 20:17:13 -0000
@@ -187,7 +187,7 @@
touch $QUILT_PC/$patch/.timestamp
fi
- if [ "$(shopt -s nullglob ; echo $QUILT_PC/$patch/*)" = "" ]
+ if [ "$(shopt -s nullglob ; echo "$QUILT_PC/$patch"/*)" = "" ]
then
printf $"Patch %s appears to be empty, applied\n" \
"$(print_patch $patch)"
_______________________________________________
Quilt-dev mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/quilt-dev
