narendly commented on a change in pull request #757: Add write REST endpoints
to helix rest for metadata store directory
URL: https://github.com/apache/helix/pull/757#discussion_r378636891
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
##########
@@ -124,7 +148,34 @@ public Response getShardingKeys(@QueryParam("realm")
String realm) {
return JSONRepresentation(responseMap);
}
- private void getHelixNamespace() {
+ @PUT
+ @Path("/metadata-store-realms/{realm}/sharding-keys/{sharding-key: .+}")
Review comment:
Why did we decide to make this a PathParam instead of a QueryParam? I think
QueryParam would be easier to use and would minimize unnecessary confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
