Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11109 )
Change subject: IMPALA-7386. Replace CatalogObjectVersionQueue with a multiset ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java File fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java: http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/main/java/org/apache/impala/catalog/CatalogObjectVersionSet.java@40 PS1, Line 40: TreeMultiset<Long> > Yea, I was trying to determine that as well as I was working on this. I was sgtm. http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java: http://gerrit.cloudera.org:8080/#/c/11109/1/fe/src/test/java/org/apache/impala/catalog/CatalogObjectVersionSetTest.java@77 PS1, Line 77: doRemove(20); > oops, missed this comment. What would the aim be of the test? Do you think Yep, since addAll and removeAll are not synchronized, addAll(1,2,3) and removeAll(1,2,3) in parallel can create various possible final states of this data structure. But I'm not totally sure how we check for consistency in that case since the output can be different each time. So it is probably enough to just test add/remove methods. -- To view, visit http://gerrit.cloudera.org:8080/11109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6c58a1acef9b02fcc26a04d048ee9cc47dc0ef Gerrit-Change-Number: 11109 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Aug 2018 02:22:04 +0000 Gerrit-HasComments: Yes
