Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11545 )
Change subject: IMPALA-5031: null ptr errors in C calls in BE tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11545/1/be/src/udf/udf.cc File be/src/udf/udf.cc: http://gerrit.cloudera.org:8080/#/c/11545/1/be/src/udf/udf.cc@521 PS1, Line 521: std::copy(buf, buf + len, result.ptr); > Does this compile to the same thing? This function is potentially a little I haven't checked, but it very well might not, or it might now but then stop doing so later. I don't want to use ubsan.h, since it pulls in glog. Would you be OK with another LIKELY condition that only triggers when buf != nullptr? -- To view, visit http://gerrit.cloudera.org:8080/11545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317ccc99549744a26d65f3e07242079faad0355a Gerrit-Change-Number: 11545 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 01 Oct 2018 18:56:29 +0000 Gerrit-HasComments: Yes
