Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/15173/2/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@66 PS2, Line 66: testCheckShortCircuitReadShouldReturnErrorForInvalidConfig() Would it be possible to consolidate this and the next into a single test? Say something like "testCheckShortCircuitConfigs()". -- To view, visit http://gerrit.cloudera.org:8080/15173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373d4037f4cee203322a398b77b75810ba708bb5 Gerrit-Change-Number: 15173 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Feb 2020 17:42:08 +0000 Gerrit-HasComments: Yes
