Michael Ho has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6657/3/be/src/runtime/tuple.h File be/src/runtime/tuple.h: PS3, Line 167: There are two different MaterializeExprs symbols to differentiate between : /// these cases when we replace the function calls during codegen. > I see. But why do we need all that in the first place? All of this code get Yes, that's another way of doing it. -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09d620e48032351ab9805825a4afb6536bed2302 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
