Todd Lipcon has posted comments on this change. Change subject: [WIP] KUDU-861 Support changing default, storage attributes ......................................................................
Patch Set 3: (1 comment) didn't get to review the patch yet, just a quick comment on back-compat http://gerrit.cloudera.org:8080/#/c/4310/3/src/kudu/master/master.proto File src/kudu/master/master.proto: Line 436: message AlterColumn { I think at this point we should actually try to retain compatibility with the old client, even if we have some "redundant" stuff in the proto -- eg you can make the 'RenameColumn' thing deprecated, but leave the server-side code in to handle it -- To view, visit http://gerrit.cloudera.org:8080/4310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I457d99ba2188ef6e439df47c0d94f2dc1a62ea6c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
