Alexey Serbin has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5946/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS1, Line 71: const security::TlsContext* tls_context > We do allow the socket and tls context to be null in one special case: when Would it be better to split it into two classes instead: { ServerNegotiationTls and ServerNegotiation } or { ServerNegotiation and ServerNegotiationGSSAPI }? Doing so would make it clearer when tls_context should or should not be present. -- To view, visit http://gerrit.cloudera.org:8080/5946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806ca360bcd168b1ab075a4c7143436a7ccbba06 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
