Todd Lipcon has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6734/2/src/kudu/security/ca/cert_management-test.cc File src/kudu/security/ca/cert_management-test.cc: PS2, Line 179: // Verify that it's possible to set the common name field up to the maximum of : // 64 characters while generating request and signing the certificate. The CN : // (common name) field goes into the subject name of the result certificate : // along with the UID (user id) field. : T not following the purpose of this test. it seems like we're redundantly testing OpenSSL here http://gerrit.cloudera.org:8080/#/c/6734/2/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: Line 297: config->hostnames = { fqdn }; if we're now only using the SAN field, can we just get rid of the CN field entirely, rather than keeping the dead code path? (maybe I'm misunderstanding). Seems like we could kill off a number of lines of code. -- To view, visit http://gerrit.cloudera.org:8080/6734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie142e76e9b2dcef3e07dd33d82b6758c746ced19 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
