Adar Dembo has posted comments on this change.

Change subject: tools: add a tool to summarize data size on a tablet or tablets
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5727/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

Line 386:     RETURN_NOT_OK_PREPEND(fs->OpenBlock(b, &rb),
> I don't see such a flag:
Huh, I could have sworn that was added at some point. Maybe it's in one of 
Dinesh's patches that was never merged.


Line 969:       .AddRequiredParameter({ kTabletIdArg, kTabletIdArgDesc })
> It already does show the sum of redo/undo/bloom/pk/each-col across each tab
Okay.


-- 
To view, visit http://gerrit.cloudera.org:8080/5727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0237f9d01f4ec332d1df545d2c2f51f64ce012
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to