Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10734 )
Change subject: KUDU-2314 Fix printing empty wal & metadata dirs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10734/3/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/10734/3/src/kudu/fs/fs_manager-test.cc@1012 PS3, Line 1012: ASSERT_STR_CONTAINS(report_str, "wal directory: " + opts.wal_root); > warning: 'opts' used after it was moved [bugprone-use-after-move] Ah oops, you can revert the std::move(). -- To view, visit http://gerrit.cloudera.org:8080/10734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8055b09f46d50b13a53bc53b28795c2bc4338d33 Gerrit-Change-Number: 10734 Gerrit-PatchSet: 3 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 18 Jun 2018 22:24:52 +0000 Gerrit-HasComments: Yes
